search

networkfusion / altra64

Alternate Everdrive64 Menu. Original release from: http://krikzz.com/forum/index.php?topic=816.0
42 stars 6 forks source link

Support for the ED64 Plus chinese clone #30

Closed gameblabla closed 5 years ago

gameblabla commented 5 years ago

There was an anti-ED64P protection in alt64 that was not removed in Altra64. This removes it and takes care of it.

The other commit allows it to being used as the default menu on the ED64P since the folder name for it is different. (which is in fact how the protection even works) This is done via a define, and ED64P specific folder name path can be enabled with -DED64PLUS.

(I just had noticed that someone else had made a similar PR before after i made this one lol... It still didn't have the option to set it as the default menu however...)

networkfusion commented 5 years ago

Unfortunately I cannot accept as this project condones the use of the device. Also, multiple changes would be needed for the PR due to the way you have implemented the strings (consider sprint). But thanks anyway.

gameblabla commented 5 years ago

I mean, even if you don't condone the use of the device, the protection should still be removed because all it does is create confusion and mess around with the save files.

Also as for the other commit, i did implement it like so because it was hardcoded as such in the source code. I could have implemented it using s(n)printf but it would have required extra steps.

I could still do a PR for removing the protection and keep the other commit for later ?

networkfusion commented 5 years ago

That was the point of the original author and I am loathed to go against his wishes... I will have a think about it and reopen if required...