LED driver

[networkimprov]

Manual: http://www.nxp.com/documents/data_sheet/PCA9632.pdf Source: https://github.com/networkimprov/linux/blob/anvl-v4.7/drivers/leds/leds-pca963x.c

Restore state after suspend/resume (not necessary if we implement alt-suspend #42)

Reset hw on reboot so led state is cleared

Set blink state based on measured timing (~78x/min) instead of spec'd 60/min.

Why does LED light green on power-off restart, but not on warm restart?

protect LED from kernel misconfiguration drivers/leds/leds-pca963x.c has the following comment: /* default to open-drain unless totem pole (push-pull) is specified */

Add a device tree binding to the driver. (Have this, possibly incomplete.)

@mranostay mentioned some other issues seen on first review of module - mutex locking issue, others?

[networkimprov]

Hm, I can't find docs on those flags to know what they all mean. Any flags that our chip can support!

[networkimprov]

Power savings of low-power mode is probably closer to 110uW, (60-15)uA*2.5V

http://www.nxp.com/documents/application_note/AN11169.pdf?cid=Brand_nxpdatafeed-web_third_party-06_05_13

[mranostay]

On Sun, Oct 2, 2016 at 12:55 PM, Liam notifications@github.com wrote:

Power savings of low-power mode is probably closer to 110uW, (60-15)uA*2.5V

Ah good to know.

http://www.nxp.com/documents/application_note/AN11169.pdf? cid=Brand_nxpdatafeed-web_third_party-06_05_13

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/networkimprov/arch-packages/issues/34#issuecomment-250991681, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwXOUdVDVwZ9LfenQeo0_MxSjdupADXks5qwAwsgaJpZM4DSn2s .

[networkimprov]

What was this in ref to? "...almost worth it to have it in the led subsystem."

Also note the change you made for led_core_suspendresume slipped into defconfig branch.

[mranostay]

On Mon, Oct 3, 2016 at 4:24 PM, Liam notifications@github.com wrote:

What was this in ref to? "...almost worth it to have it in the led subsystem."

Don't make it only a pca9632 driver change but have the LED subsystem set the flag from device tree property Same amount of work.

Also note the change you made for led_core_suspendresume slipped into defconfig branch.

Gah... ok I'll fix it in the defconfig branch since you switched branches already.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/networkimprov/arch-packages/issues/34#issuecomment-251255464, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwXOQXhByqtT6IhIzHF4-ZnLipjqB2yks5qwY6ogaJpZM4DSn2s .

[networkimprov]

The maintainers would want the scheme to work for all the options, so prob more work.

Should finish this fix on the pca96xx branch (or a new one and delete pca96xx).

[networkimprov]

Let's shelve the suspendresume patch in favor of implementing alt-suspend.

[networkimprov]

Can you drop links here to mailing list threads for suspendresume and blink scaling?

[mranostay]

On Wed, Oct 5, 2016 at 11:34 AM, Liam notifications@github.com wrote:

Can you drop links here to mailing list threads for suspendresume and blink scaling?

Need to submit the blink scaling shortly. I suspect that will get some comments :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/networkimprov/arch-packages/issues/34#issuecomment-251760341, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwXOZhJ54ydI5euwPIa1qCe5J1I6wsjks5qw-3HgaJpZM4DSn2s .

[networkimprov]

Ping for upstreaming blink scaling.

[mranostay]

On Wed, Oct 19, 2016 at 4:07 PM, Liam notifications@github.com wrote:

Ping for upstreaming blink scaling.

Seems to have no huge objections so far upstream:

https://patchwork.ozlabs.org/patch/681795/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/networkimprov/arch-packages/issues/34#issuecomment-254966529, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwXOUhxxCWUjX3lPA2CJiVAPd8L73RJks5q1qKigaJpZM4DSn2s .

[networkimprov]

Maybe keep a count of lit LEDs and ++/-- it on set?

[networkimprov]

Does scaling patch need tuning for comments?

[mranostay]

On Sun, Oct 23, 2016 at 3:25 PM, Liam notifications@github.com wrote:

Does scaling patch need tuning for comments?

Nope they didn't have an issue with comments. Just waiting for a few Ack-by: namely Rob Herring

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/networkimprov/arch-packages/issues/34#issuecomment-255619024, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwXOZ2GvqBfQfu5ZSvW_aCxGuti7RgNks5q297wgaJpZM4DSn2s .

[mranostay]

On Fri, Oct 21, 2016 at 1:59 AM, Liam notifications@github.com wrote:

Maybe keep a count of lit LEDs and ++/-- it on set?

Yeah v2 on the list is using that suggestion... seems any web mirror of linux-leds list is down so can't post a link.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/networkimprov/arch-packages/issues/34#issuecomment-255330294, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwXORQO7bfOtCTkE-SYRqfniq1mpZpeks5q2H74gaJpZM4DSn2s .

[mranostay]

Ok v5 is likely getting in (still need Ack's from the list).. fixed the code logic and mutex issues raise by the list.

Applied against our tree: https://github.com/networkimprov/linux/commit/1f48949b23688faf8bc4bfe43cd43594e3692ccd