networknt / json-schema-validator

A fast Java JSON schema validator that supports draft V4, V6, V7, V2019-09 and V2020-12
Apache License 2.0
836 stars 324 forks source link

Allow tracking of json node location information #1046

Closed justin-tay closed 4 months ago

justin-tay commented 4 months ago

This allows easier tracking of the json node location information such as the line and column number by providing a default implementation that can be configured.

This is not configured by default as it will adversely affect performance.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 47.71242% with 80 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (48ca3c2) to head (5f896a3). Report is 16 commits behind head on master.

Files Patch % Lines
...ma/serialization/node/LocationJsonNodeFactory.java 35.71% 17 Missing and 1 partial :warning:
...ain/java/com/networknt/schema/utils/JsonNodes.java 57.89% 5 Missing and 3 partials :warning:
...in/java/com/networknt/schema/JsonNodeLocation.java 0.00% 7 Missing :warning:
...erialization/node/JsonLocationAwareBinaryNode.java 0.00% 7 Missing :warning:
...n/java/com/networknt/schema/JsonSchemaFactory.java 76.00% 4 Missing and 2 partials :warning:
...serialization/node/JsonLocationAwareArrayNode.java 40.00% 6 Missing :warning:
...lization/node/JsonLocationAwareBigIntegerNode.java 0.00% 4 Missing :warning:
...erialization/node/JsonLocationAwareDoubleNode.java 0.00% 4 Missing :warning:
...serialization/node/JsonLocationAwareFloatNode.java 0.00% 4 Missing :warning:
.../serialization/node/JsonLocationAwareLongNode.java 0.00% 4 Missing :warning:
... and 4 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1046 +/- ## ============================================ - Coverage 78.90% 78.65% -0.26% - Complexity 1965 2031 +66 ============================================ Files 172 191 +19 Lines 6352 6600 +248 Branches 1255 1267 +12 ============================================ + Hits 5012 5191 +179 - Misses 867 930 +63 - Partials 473 479 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.