Closed justin-tay closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.74%. Comparing base (
48ca3c2
) to head (e11488a
). Report is 19 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This fixes the test failure from the JSON Schema Test Suite in
optional/ecmascript-regex.json
asjoni
does not detect invalid escapes.This makes the following changes
regex
format has been changed to also follow the configuration of whether to useecma-262
compliant regex. Previously it always used thejdk
regex.JoniRegularExpression
implementation uses a regex to detect if an invalid escape is used asjoni
doesn't detect invalid escapes. In actuality it's upstreamOniguruma
doesn't actually support ecma as a syntax.optional/ecmascript-regex.json
has been updated. In actuality it doesn't change anything but it is clearer that"format": "regex"
is used in the testoptional/ecmascript-regex.json
test