Closed justin-tay closed 3 weeks ago
Attention: Patch coverage is 50.00000%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 78.77%. Comparing base (
48ca3c2
) to head (8ed4f5a
). Report is 29 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/main/java/com/networknt/schema/JsonSchema.java | 43.47% | 13 Missing :warning: |
...c/main/java/com/networknt/schema/OutputFormat.java | 75.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Deprecate
validateAndCollect
in favor of explicitly callingloadCollectors
.This also deprecates the related
loadCollectors
configuration inSchemaValidatorsConfig
.This makes the
CollectorContext.loadCollectors()
method public to be explicitly called instead of relying on theSchemaValidatorsConfig
.Proper usage of the
validateAndCollect
method is confusing. It relies on a configuration set inSchemaValidatorsConfig
that is configured on a per schema basis. It immediately runsloadCollectors
if set totrue
and will never be able to runloadCollectors
if set tofalse
as the method is notpublic
.The documentation has been updated to reflect the replacement, which is to explicitly create the
CollectorContext
to be shared and set for each execution. FinallyloadCollectors
can be called a the end if needed.