networknt / json-schema-validator

A fast Java JSON schema validator that supports draft V4, V6, V7, V2019-09 and V2020-12
Apache License 2.0
859 stars 325 forks source link

Clean up code #1130

Closed jkosternl closed 4 days ago

jkosternl commented 6 days ago
codecov-commenter commented 6 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.14%. Comparing base (48ca3c2) to head (f1c64c9). Report is 69 commits behind head on master.

Files with missing lines Patch % Lines
.../java/com/networknt/schema/utils/JsonNodeUtil.java 50.00% 1 Missing and 1 partial :warning:
...java/com/networknt/schema/utils/StringChecker.java 0.00% 0 Missing and 2 partials :warning:
src/main/java/com/networknt/schema/JsonSchema.java 85.71% 0 Missing and 1 partial :warning:
...n/java/com/networknt/schema/JsonSchemaFactory.java 66.66% 1 Missing :warning:
...ava/com/networknt/schema/PrefixItemsValidator.java 0.00% 0 Missing and 1 partial :warning:
...om/networknt/schema/format/IriReferenceFormat.java 0.00% 0 Missing and 1 partial :warning:
.../main/java/com/networknt/schema/utils/RFC5892.java 94.44% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1130 +/- ## ============================================ - Coverage 78.90% 78.14% -0.76% - Complexity 1965 2061 +96 ============================================ Files 172 201 +29 Lines 6352 6850 +498 Branches 1255 1252 -3 ============================================ + Hits 5012 5353 +341 - Misses 867 1030 +163 + Partials 473 467 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stevehu commented 4 days ago

Java 8 can compile the code without any issues. Thanks.