search

networknt / json-schema-validator

A fast Java JSON schema validator that supports draft V4, V6, V7, V2019-09 and V2020-12
Apache License 2.0
855 stars 325 forks source link

665: Can't load JSON schemas with URN value in id field #906

Closed martin-sladecek closed 11 months ago

martin-sladecek commented 11 months ago

(Hopefully) a fix for #665. Added a special handling for "urn:" URIs When an the same URN is present in some id/anchor, a reference is created. Otherwise, it falls back to the current logic and a special URIFetcher needs to be present.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2971b79) 79.42% compared to head (ec40664) 79.39%. Report is 2 commits behind head on master.

Files Patch % Lines
...n/java/com/networknt/schema/uri/URNURIFactory.java 25.00% 6 Missing :warning:
src/main/java/com/networknt/schema/JsonSchema.java 0.00% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #906 +/- ## ============================================ - Coverage 79.42% 79.39% -0.03% - Complexity 1222 1229 +7 ============================================ Files 121 122 +1 Lines 3897 3911 +14 Branches 737 740 +3 ============================================ + Hits 3095 3105 +10 - Misses 515 520 +5 + Partials 287 286 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martin-sladecek commented 11 months ago

Hi @stevehu, just wanted to check, when can I expect the new release to come out? Thanks!

stevehu commented 11 months ago

The new release, 1.0.88, is out. Thanks.