search

networknt / json-schema-validator

A fast Java JSON schema validator that supports draft V4, V6, V7, V2019-09 and V2020-12
Apache License 2.0
822 stars 323 forks source link

Fix for required annotations for evaluation not collected #944

Closed justin-tay closed 7 months ago

justin-tay commented 7 months ago

Closes #943

The current logic for determining if annotations are needed to be collected for evaluation checks if the keyword exists in the meta schema of where that keyword is. eg. the properties validator is checking for the unevaluatedProperties but the properties may be existing in a Draft 7 schema where unevaluatedProperties is not a keyword but the outer schema is a Draft 2020-12 schema.

The check is now removed and it just checks if a validator with that keyword exists on the evaluation path.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (49a44c9) 78.85% compared to head (2f060d9) 78.85%.

Files Patch % Lines
...va/com/networknt/schema/output/OutputUnitData.java 84.61% 1 Missing and 1 partial :warning:
...va/com/networknt/schema/AbstractJsonValidator.java 0.00% 0 Missing and 1 partial :warning:
...n/java/com/networknt/schema/BaseJsonValidator.java 90.00% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #944 +/- ## ============================================ - Coverage 78.85% 78.85% -0.01% - Complexity 1687 1690 +3 ============================================ Files 157 157 Lines 5652 5661 +9 Branches 1068 1068 ============================================ + Hits 4457 4464 +7 - Misses 794 798 +4 + Partials 401 399 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.