FailFast Property Does Not Throw JsonSchemaException for Validation Errors in v1.3.1

networknt / json-schema-validator

A fast Java JSON schema validator that supports draft V4, V6, V7, V2019-09 and V2020-12

Apache License 2.0

822 stars 323 forks source link

FailFast Property Does Not Throw JsonSchemaException for Validation Errors in v1.3.1 #960

Closed OgiDD closed 7 months ago

OgiDD commented 7 months ago

After upgrading to version 1.3.1, a bug has been identified where the failFast property fails to throw a JsonSchemaException when validation errors are discovered. It's important to note that this issue did not occur in version 1.3.0

justin-tay commented 7 months ago

Sorry, I think I missed this out as a breaking change. Setting failFast now just returns normally as a validation message.

OgiDD commented 7 months ago

Thanks, @justin-tay 🙂 So, is this the expected behavior for failFast from now on?

justin-tay commented 7 months ago

Yes. This was partially done to distinguish the fail fast result from true exceptions such as when references could not be resolved. Sorry for the inconvenience.