Closed justin-tay closed 6 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
7cda40e
) 78.65% compared to head (8699200
) 78.59%.
Files | Patch % | Lines |
---|---|---|
...n/java/com/networknt/schema/MaxItemsValidator.java | 50.00% | 1 Missing :warning: |
...om/networknt/schema/UnevaluatedItemsValidator.java | 83.33% | 0 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This makes the following changes
unevaluatedProperties
andunevaluatedItems
when using a schema that is notfalse
now just let those messages be returned instead of modifying the message. This is consistent with the other validators handling of this eg.additionalProperties
.oneOf
now returns the matching indexes. Note that in a typical short circuit case this will only return 2 instead of potentially more.An attempt was made to fix the translations of
jsv-messages.properties
. Most of them are all corrupt and have?
or�
characters. Others are encoded in UTF-8 which is not supported in Java 8. UTF-8 in resource bundles are only supported from Java 9. In Java 8 they must be encoded in ISO-8859-1 with unsupported characters escaped. ALocaleTest
was added to ensure that the translated messages are working as expected. A native speaker would be required for a proper fix.