networknt / json-schema-validator

A fast Java JSON schema validator that supports draft V4, V6, V7, V2019-09 and V2020-12
Apache License 2.0
822 stars 323 forks source link

Fix validation messages #969

Closed justin-tay closed 6 months ago

justin-tay commented 6 months ago

This makes the following changes

An attempt was made to fix the translations of jsv-messages.properties. Most of them are all corrupt and have ? or characters. Others are encoded in UTF-8 which is not supported in Java 8. UTF-8 in resource bundles are only supported from Java 9. In Java 8 they must be encoded in ISO-8859-1 with unsupported characters escaped. A LocaleTest was added to ensure that the translated messages are working as expected. A native speaker would be required for a proper fix.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7cda40e) 78.65% compared to head (8699200) 78.59%.

Files Patch % Lines
...n/java/com/networknt/schema/MaxItemsValidator.java 50.00% 1 Missing :warning:
...om/networknt/schema/UnevaluatedItemsValidator.java 83.33% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #969 +/- ## ============================================ - Coverage 78.65% 78.59% -0.06% Complexity 1810 1810 ============================================ Files 161 161 Lines 5893 5887 -6 Branches 1116 1119 +3 ============================================ - Hits 4635 4627 -8 Misses 833 833 - Partials 425 427 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.