networknt / json-schema-validator

A fast Java JSON schema validator that supports draft V4, V6, V7, V2019-09 and V2020-12
Apache License 2.0
822 stars 323 forks source link

Make ethlo excludable #974

Closed justin-tay closed 6 months ago

justin-tay commented 6 months ago

Closes #973

This makes the ethlo dependency excludable. This isn't the same as making it optional as optional dependencies need to be explicitly added, while excludable needs to be explicitly excluded.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (bc93b44) 78.75% compared to head (0519d3f) 78.63%.

Files Patch % Lines
...va/com/networknt/schema/format/DateTimeFormat.java 43.75% 7 Missing and 2 partials :warning:
.../main/java/com/networknt/schema/utils/Classes.java 40.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #974 +/- ## ============================================ - Coverage 78.75% 78.63% -0.12% - Complexity 1850 1851 +1 ============================================ Files 164 165 +1 Lines 5987 6001 +14 Branches 1146 1147 +1 ============================================ + Hits 4715 4719 +4 - Misses 837 846 +9 - Partials 435 436 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.