search

networknt / light-bot

A microservice based DevOps agent that handles multiple repositories and dependencies
Apache License 2.0
7 stars 3 forks source link

DockerBuildCmd should execute docker commands to build docker image #6

Open DineshAlapati opened 6 years ago

DineshAlapati commented 6 years ago

DockerBuildCmd utility class relies on build.sh script to build docker image. As light-codegen does not generate this file, we should execute docker commands instead of executing build.sh script.

stevehu commented 6 years ago

@DineshAlapati good catch. Is it possible to have a generic build.sh? If yes, we can put it into light-codegen. It is much easy to use build.sh instead docker command line. Thanks

DineshAlapati commented 6 years ago

Yes we can have a generic build.sh that can be generated from light-codegen but, build.sh requires image name to publish to docker hub. User has to include this image name before running it for first time or we can let the script to take this value as a argument.

stevehu commented 6 years ago

The image name should be in sync with service name defined in the config.json file. The only variable would be the organization of docker hub. I will try something tonight and we can have a chat tomorrow. Thanks.