search

networkop / meshnet-cni

a (K8s) CNI plugin to create arbitrary virtual network topologies
BSD 3-Clause "New" or "Revised" License
116 stars 28 forks source link

Make CNI DEL idempotent #74

Closed Cerebus closed 1 year ago

Cerebus commented 1 year ago

Closes #70

This is muy hacky, but it means no breaking changes to Topology. PR opened to get comments, I'll test it out locally over the week and remove the draft if I think it's functional and stable.

I would rather rethink the whole of status tracking, b/c I think there might be some corner cases where this hack won't work, but

Cerebus commented 1 year ago

A few days in operations with no issues on my end, so removing draft.

Cerebus commented 1 year ago

Rebased b/c new commits on master.

ETA: Yeah, I should've just merged. Habits of working alone, sorry.

networkop commented 1 year ago

Thanks, I'm afk this week, will review once I'm back