search

networkop / meshnet-cni

a (K8s) CNI plugin to create arbitrary virtual network topologies
BSD 3-Clause "New" or "Revised" License
116 stars 28 forks source link

Grpc-Wire Reconciliation #80

Closed kingshukdev closed 1 year ago

kingshukdev commented 1 year ago

This PR contains the following addons and changes :-

  1. Reconciliation support for grpc wires and documentation
  2. Enhanced ‘skip’ marking for each link and check the same before link creation.
  3. Reorganize grpc wire code in multiple files.
  4. Design doc - meshnet-gwire-recon.pdf
networkop commented 1 year ago

looks good on the first pass 👍 will have another look tomorrow

networkop commented 1 year ago

looks good on the second pass. thanks @kingshukdev. a couple of thoughts:

  1. Would it make sense to add a separate e2e test case for grpc reconciliation in addition to multi-link test?
  2. Can you add the design document (either as pdf or markdown) to this PR for future reference?
kingshukdev commented 1 year ago

@networkop

  1. Recon unit tests are present in - "daemon/grpcwire/gwire_recon_test.go". They get executed when one does "make test" or "make recon-test"
  2. Added the design doc in the initial comment of this PR.