search

networkservicemesh / cmd-forwarder-sriov

SR-IOV Forwarder CMD application repository
Apache License 2.0
1 stars 14 forks source link

move device plugin server into common repo #163

Closed pperiyasamy closed 3 years ago

pperiyasamy commented 3 years ago

Can we move device plugin server implementation into a common repo like sdk-k8s or sdk-sriov so that it can also be reused by ovs forwarder (going to get implemented) that has support for smartnic based VFs. The forwarder just have to rely this StartServers API to start the device plugin server with required token pools based on the sriov.conf file.

denis-tingaikin commented 3 years ago

Related to https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/main/internal/deviceplugin/server.go

As I can see it has dep on "github.com/networkservicemesh/sdk-sriov/pkg/tools/tokens"

Actually, the dep is using only for https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/main/internal/deviceplugin/server.go#L268

So to remove the dependency on sdk-sriov I would be suggesting just adding the method ToEnv into https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/main/internal/deviceplugin/server.go#L37.

Then deviceplugin server can be moved into sdk-k8s and can be reusable :)

denis-tingaikin commented 3 years ago

Summons @Bolodya1997

Bolodya1997 commented 3 years ago

I am not looking forward to separate ToEnv and FromEnv methods to different repos, but I suppose that we can move whole tokens package to sdk tools, because it doesn't have any dependencies on some SR-IOV specific stuff. After that we definitely can move deviceplugin to the sdk-k8s.