search

networkservicemesh / cmd-nse-icmp-responder

Apache License 2.0
2 stars 21 forks source link

Group IPAM conflicts with strict policy #614

Open Ex4amp1e opened 1 week ago

Ex4amp1e commented 1 week ago

Steps to reproduce: Configure envs on endpoint

        - name: NSM_IPAM_POLICY
          value: strict
        - name: NSM_CIDR_PREFIX
          value: 172.16.1.100/27,2001:db8::/116

Actual: only ipv6 pool is configured on client and endpoint. Healing is not working after endpoint and registry restart.

Expected: 2 ip pools, healing works well.

Solution: Place IPAM policy over group policy

NikitaSkrynnik commented 1 week ago

Group IPAM: https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/ipam/groupipam/server.go Strict IPAM: https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/ipam/strictipam/server.go They are used here: https://github.com/networkservicemesh/cmd-nse-icmp-responder/blob/main/main.go#L248