search

networkservicemesh / fanout

Repository for the coredns fanout plugin used by Network Service Mesh
Apache License 2.0
19 stars 18 forks source link

fix: return last err from processClient #37

Closed xonvanetta closed 3 years ago

xonvanetta commented 3 years ago

It didn't say why it failed just that it reach max attempts. This was used to debug a error in coredns.

This is the issue we found out after we noticed that it was working without cache pluigin. https://github.com/coredns/coredns/issues/4735

denis-tingaikin commented 3 years ago

I think this patch makes sense.

Could you please look at failed job https://github.com/networkservicemesh/fanout/pull/37/checks?check_run_id=3364249178?

xonvanetta commented 3 years ago

Sure can do, but in a short while, not currently at home.

Also could we do something like attempt limit has been reached, last err: %w?

xonvanetta commented 3 years ago

@denis-tingaikin bump

denis-tingaikin commented 3 years ago

@xonvanetta Merged this to help @Funami580 catch the problem with TLS.

Be free to resolve comment in separate PR.

Thanks!