search

networkservicemesh / govpp

Apache License 2.0
0 stars 5 forks source link

Add check that `go generate` do not produce changes for the branch #30

Open denis-tingaikin opened 6 months ago

denis-tingaikin commented 6 months ago

Motivation

When we add a patch for the govpp we should make sure that we don't have a diff when run go generate.

TODO

References

Incident https://github.com/networkservicemesh/govpp/pull/29 Similar job https://github.com/networkservicemesh/.github/blob/main/.github/workflows/cmd-gogenerate.yaml

VitalyGushin commented 6 months ago

@denis-tingaikin Seems like the desired behaviour is already implemented here: https://github.com/networkservicemesh/govpp/blob/3c0a753ca3bfcbe4f70e48ec7f4f3e1769602d91/.github/workflows/ci.yaml#L107-L111

denis-tingaikin commented 6 months ago

It seems like it doesn't work; see https://github.com/networkservicemesh/govpp/pull/27. There is green CI, but actually go generatewas required. That is what we did after https://github.com/networkservicemesh/govpp/pull/29