networkservicemesh / networkservicemesh

The Hybrid/Multi-cloud IP Service Mesh
https://www.networkservicemesh.io/
Apache License 2.0
505 stars 142 forks source link

spire namespace missing on a clean helm deploy #2195

Open One-ders opened 4 years ago

One-ders commented 4 years ago

Expected Behavior

Installing NSM with helm3 from networkservicemesh/deployments/helm/nsm should render a working NSM system.

Current Behavior

The installation fails with error, that the namespace spire does not exist.

Failure Information (for bugs)

Steps to Reproduce

with a system that previously did not run NSM, or as I had an older version of NSM which I removed.

system info: [root@kube-master ~]# kubectl version Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.8", GitCommit:"35dc4cdc26cfcb6614059c4c6e836e5f0dc61dee", GitTreeState:"clean", BuildDate:"2020-06-26T03:43:27Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.8", GitCommit:"35dc4cdc26cfcb6614059c4c6e836e5f0dc61dee", GitTreeState:"clean", BuildDate:"2020-06-26T03:36:03Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

[root@kube-master ~]# helm version version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}

If you have nsm installed remove it. check if you have a spire namespace lingering, if so remove it.

[root@kube-master ~]# kubectl get namespaces NAME STATUS AGE default Active 314d kube-node-lease Active 314d kube-public Active 314d kube-system Active 314d spire Active 3d20h [root@kube-master ~]# kubectl delete namespace spire namespace "spire" deleted

check git commit id:

cd networkservicemesh/deployments/helm

git log commit 7bda1b173bd43d678745416c69e7197876aff332 (HEAD -> master, origin/master, origin/HEAD) Author: xzfc xzfc@users.noreply.github.com Date: Mon Sep 21 06:10:46 2020 +0000

Put limits on containers created by admission-webhook (#2188)

Signed-off-by: Albert Safin <albert.safin@xored.com>

Then install:

[root@kube-master helm]# helm install nsm nsm Error: namespaces "spire" not found

[root@kube-master helm]# helm ls NAME NAMESPACE REVISION UPDATED STATUS CHART APP VERSION nsm default 1 2020-09-25 11:52:26.112214522 +0200 CEST failed nsm-0.2.0 0.2.0

helm delete nsm

Ok, so add namespace spire.

[root@kube-master helm]# kubectl create namespace spire namespace/spire created

root@kube-master helm]# helm install nsm nsm NAME: nsm LAST DEPLOYED: Fri Sep 25 11:54:32 2020 NAMESPACE: default STATUS: deployed REVISION: 1 TEST SUITE: None

[root@kube-master helm]# helm ls NAME NAMESPACE REVISION UPDATED STATUS CHART APP VERSION nsm default 1 2020-09-25 11:54:32.957777121 +0200 CEST deployed nsm-0.2.0 0.2.0

Works fine now, after manually creating the spire namespace

edwarnicke commented 4 years ago

@haiodo @denis-tingajkin Could someone get a look at this?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had activity in 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.