Closed szvincze closed 2 years ago
Same issue here. I expect PRs to contain a minimal amount of commits or if possible just one with the key change that PR is doing. There quite some commits duplicated here. Can you clean this to the only commits necessary to this change? If needed you can rebase it with the recently merged #52
I marked this one as draft and will rebase when #53 will be merged on the master. Next time I will create smaller PRs with minimal commits but this time there was too long time without merging and I added many things gradually based on each others.
Same issue here. I expect PRs to contain a minimal amount of commits or if possible just one with the key change that PR is doing. There quite some commits duplicated here. Can you clean this to the only commits necessary to this change? If needed you can rebase it with the recently merged #52
I marked this one as draft and will rebase when #53 will be merged on the master. Next time I will create smaller PRs with minimal commits but this time there was too long time without merging and I added many things gradually based on each others.
Got it! @szvincze Thanks again! So #53 is merged now. You may cleanup the commits and I will review it.
Got it! @szvincze Thanks again! So #53 is merged now. You may cleanup the commits and I will review it. @acmenezes: Now it contains only the needed 5 commits, however not small ones but hopefully not too chaotic.
I accidentally approved this. But check on the comments. There are some requested changes.
Sure, I will work on the changes and come back for review.
@acmenezes I sent another commit with the changes you requested. Please review it.