Added admission-webhook-k8s etc.

networkservicemesh / nsm-operator

A kubernetes operator for deploying and managing Network Service Meshes

Apache License 2.0

9 stars 8 forks source link

Added admission-webhook-k8s etc. #54

Closed szvincze closed 2 years ago

szvincze commented 2 years ago

admission-webhook-k8s deployment and service added.
exclude-prefixes container added to NSMGR pod.
Forwarder reconciler is fixed.
Multi-forwarder scenario is implemented properly.
Updated samples to work with new variables.
Probes added to forwarder-vpp and nsmgr.
Default images handling fixed.
registry-service type changed to LoadBalancer.

szvincze commented 2 years ago

Same issue here. I expect PRs to contain a minimal amount of commits or if possible just one with the key change that PR is doing. There quite some commits duplicated here. Can you clean this to the only commits necessary to this change? If needed you can rebase it with the recently merged #52

I marked this one as draft and will rebase when #53 will be merged on the master. Next time I will create smaller PRs with minimal commits but this time there was too long time without merging and I added many things gradually based on each others.

acmenezes commented 2 years ago

Same issue here. I expect PRs to contain a minimal amount of commits or if possible just one with the key change that PR is doing. There quite some commits duplicated here. Can you clean this to the only commits necessary to this change? If needed you can rebase it with the recently merged #52

I marked this one as draft and will rebase when #53 will be merged on the master. Next time I will create smaller PRs with minimal commits but this time there was too long time without merging and I added many things gradually based on each others.

Got it! @szvincze Thanks again! So #53 is merged now. You may cleanup the commits and I will review it.

szvincze commented 2 years ago

Got it! @szvincze Thanks again! So #53 is merged now. You may cleanup the commits and I will review it. @acmenezes: Now it contains only the needed 5 commits, however not small ones but hopefully not too chaotic.

szvincze commented 2 years ago

I accidentally approved this. But check on the comments. There are some requested changes.

Sure, I will work on the changes and come back for review.

szvincze commented 2 years ago

@acmenezes I sent another commit with the changes you requested. Please review it.