networkservicemesh / sdk

Apache License 2.0
35 stars 35 forks source link

Use in memory logging for each sandbox test #1152

Open denis-tingaikin opened 2 years ago

denis-tingaikin commented 2 years ago

Problem statement

If test failed on ci we can not get logs from nsm components.

Solution

Always write logs into memory logger.

If t.Failed() then push all logs into stdout.

Memory logger implementation

  1. add new pkg into tools/log/memorylogger
  2. use the logger with https://github.com/networkservicemesh/sdk/blob/main/pkg/tools/log/logger.go#L75 for each test
  3. write logs into stdout if t.Failed()
NikitaSkrynnik commented 2 years ago

Blocked by https://github.com/networkservicemesh/sdk/issues/1182