networkservicemesh / sdk

Apache License 2.0
34 stars 36 forks source link

Fix leaks in 'trace' element #1635

Closed denis-tingaikin closed 1 week ago

denis-tingaikin commented 4 months ago

https://github.com/networkservicemesh/sdk/commit/15fe129fec59610b4da3b4887f2d7b29d4705d9f

Steps to reproduce

It's actual for metrics and for logger spans (when otel is disabled)

  1. Run https://github.com/networkservicemesh/deployments-k8s/tree/main/examples/observability/jaeger_and_prometheus
  2. Continus scale client/endpoint
  3. Check mem profiles

Actual: Memory leaks. Expected: No memory leaks.

Action plan: (provided by @VitalyGushin )

denis-tingaikin commented 4 months ago

@VitalyGushin profiles:

forwarder-vpp_memprofiles_20240519135433.tar (1).gz nsmgr_memprofiles_20240519135233.tar (1).gz

denis-tingaikin commented 1 week ago

Finally, we've found a root cause with the trace element, and it will be considered in the separate issue https://github.com/networkservicemesh/sdk/issues/1667