search

networkteam / Netwokteam.Neos.SentryClient

Sentry client for neos cms
MIT License
3 stars 2 forks source link

Incompatible to neos/flow >= 7.3.6 #10

Closed mgrundkoetter closed 2 years ago

mgrundkoetter commented 2 years ago

In version 7.3.6 of neos/flow the AbstractExceptionHandler::echoExceptionCli signature changed from

protected function echoExceptionCli(\Throwable $exception) to protected function echoExceptionCli(\Throwable $exception, bool $exceptionWasLogged)

So this causes an error now:

PHP Fatal error: Declaration of Networkteam\SentryClient\Handler\DebugExceptionHandler::echoExceptionCLI(Throwable $exception) must be compatible with Neos\Flow\Error\AbstractExceptionHandler::echoExceptionCli(Throwable $exception, bool $exceptionWasLogged)

Temporary solution is to pin the package to 7.3.5 in composer.json.

mgrundkoetter commented 2 years ago

Oops, wrong package, this one is correct: https://github.com/networkteam/Networkteam.SentryClient/issues/40