search

networkteam / Networkteam.Neos.Shariff

Integrate Shariff, social buttons with privacy into Neos CMS
GNU General Public License v2.0
7 stars 13 forks source link

TASK: Declare compatible with Neos 8 and Flow 8 #27

Closed kdambekalns closed 9 months ago

kdambekalns commented 2 years ago

This drops compatibility with Neos < 5.3 / Flow < 6.3 and raises the minimum PHP version to 7.4

kdambekalns commented 2 years ago

Note: this won't work on Neos 8 since there is no released version of heise/shariff yet with support for PHP 8.

A PR exists (https://github.com/heiseonline/shariff-backend-php/pull/181) but that needs to be pulled in manually for now…

dlubitz commented 1 year ago

Shariff has released the 10.0 version with PHP 8.1 compatibility. https://github.com/erkenes/shariff-backend-php/releases/tag/10.0.0

nilsjung commented 9 months ago

Sorry to disappoint but if I'm correct erkenes/heise-shariff has released v10 and not heise/shariff.

We internally use also some hacky solutions to bypass the missing heise/shariff update. But maybe its time to use erkenes/heise-shariff as dependency here.

nilsjung commented 9 months ago

Heise has released v10, thus, I will finally merge this PR

https://github.com/heiseonline/shariff-backend-php/releases/tag/v10.0.0