search

networkteam / ember-cli-maskedinput

Masked <input/> Ember component based on inputmask-core (no jQuery)
MIT License
25 stars 11 forks source link

Fix ref incompatibility with newer ember #21

Closed ef4 closed 1 year ago

ef4 commented 1 year ago

ember-ref-modifier is unsupported in favor of ember-ref-bucket. This change is enough to get things working on ember 3.28 for me.

This change probably bumps the minimum supported ember version for this library to 3.20, since that is the oldest ember-ref-bucket supports.

Also, fellow app upgraders should take care that they aren't getting multiple conflicting copies of ember-modifier, because a newer version of ember-modifier will come as a dependency of ember-ref-bucket. In my case it was necessary to use yarn resolutions to put everything onto ember-modifier ^3.0.0.

hlubek commented 1 year ago

Thx for your PR, this is fixed in version 3.0.0

pzubar commented 1 year ago

Hello, @hlubek! I've noticed that version 3.0.0 depends on ember-ref-bucket "^3.0.0" that uses ember-modifier "^2.1.1". Is it possible to bump ember-ref-bucket to version 4 or above?

I've also noticed that one of the commits contained the bump to version 5, but this change was reverted or something like that. Does this upgrade break anything?

Thank you in advance!