search

networkteam / sentry_client

TYPO3 Extension for exception logging with sentry, see http://www.getsentry.com
33 stars 35 forks source link

[FEATURE] Pass SENTRY_SERVER_NAME environment variable to Sentry #75

Closed cweiske closed 1 year ago

christophlehmann commented 1 year ago

Thanks for the PR, but i won't merge it, because we don't use that flag and the environment variable is not an official coming with the SDK.

With the next release you can set it pretty easily like $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['sentry_client']['options']['server_name'] = 'your server name';

cweiske commented 1 year ago

Then please cherry-pick the doc URL fix commit.

cweiske commented 1 year ago

oh, you did :)

cweiske commented 1 year ago

@christophlehmann is it true that I can use 

$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['sentry_client']['options']['server_name'] = 'your server name';

now with 4.3.0? I don't see that in the code.

Also, it should probably be 

$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['sentry_client']['options']['server_name'] = 'your server name';

(EXTENSIONS instead of EXTCONF)

christophlehmann commented 1 year ago

now with 4.3.0?

Not yet. With upcoming release, see https://github.com/networkteam/sentry_client/pull/76

(EXTENSIONS instead of EXTCONF)

Its intended to use EXTCONF, because its form is free while EXTENSIONS streamlines variables from ext_conf_template.txt