networktocode / diffsync

A utility library for comparing and synchronizing different datasets.
https://diffsync.readthedocs.io/
Other
155 stars 26 forks source link

Upgrade structlog, packaging dependencies #211

Closed jamesharr closed 1 year ago

jamesharr commented 1 year ago

This upgrades the structlog and packaging dependencies. I also bumped the patch version number. No clue if this is appropriate or not.

This came about because I ran into an issue where one tool we use during development (black version 23) requires packaging >= 22.0, and our project is making use of structlog 22.3.0.

At first glance, these packages seem fairly API compatible between versions, so my logic was to loosen up the requirement ranges a bit and allow further upgrades.

Again, I'm not sure if this is correct behavior or not, but I figured I'd throw this out there and see where the conversation goes.

Kircheneer commented 1 year ago

I am unsure why black is failing in the CI, but would you mind running black on the code once and pushing that? That should fix the failing CI step.

As to bumping the patch version, can you revert that change? This should happen in a separate release PR.

jamesharr commented 1 year ago

I'll get it updated today in a little bit.

I know what's going on with black, they do a style change once a year when they bump the major rev. 23 introduces a change that removes an empt.y newline at the start of a code block.

I'll have more info on that when I update the PR

jamesharr commented 1 year ago

review suggestions implemented

If you're curious, this is the black 23.x style change I was referring to, but it seems like the changes are more subtle here... https://github.com/psf/black/pull/3035

Kircheneer commented 1 year ago

There are still some weird CI things happening. I have updated the CI setup in the following PR: https://github.com/networktocode/diffsync/pull/212 Once that's in, you should be able to rebase and then be good.

Kircheneer commented 1 year ago

PR is in, just rebase onto develop now and it should work.

jamesharr commented 1 year ago

Alright, I think/hope it should be good now

Kircheneer commented 1 year ago

LGTM @jamesharr! Thanks for staying patient here.