networktocode / diffsync

A utility library for comparing and synchronizing different datasets.
https://diffsync.readthedocs.io/
Other
155 stars 26 forks source link

Pydantic 2.0 Migration #236

Closed Kircheneer closed 1 year ago

Kircheneer commented 1 year ago

As part of the pydantic 2.0 release, a suite of breaking changes were released. We need to investigate where this breaks diffsync.

Issues already identified

For more see here.

Kircheneer commented 1 year ago

https://github.com/pydantic/bump-pydantic

ghost commented 1 year ago

https://docs.pydantic.dev/latest/usage/model_config/#extra-attributes

extra=allow is still possible as I am using it, it's only not allowed in pydantic.dataclass

Kircheneer commented 1 year ago

Due to a change where fields of type Optional now need explicit None defaults, this change can not be considered backwards-compatible.

Kircheneer commented 1 year ago

Closed with #240