search

networktocode / netutils

Python library that is a collection of functions and objects for common network automation tasks.
https://netutils.readthedocs.io/
Other
214 stars 48 forks source link

Add Mappings for DNA Center #519

Closed jdrew82 closed 4 months ago

jdrew82 commented 4 months ago

This PR is to add the forward and reverse mappings for DNA Center. I'm a bit unsure how to handle IOS-XE for the reverse though as you can't have two cisco_ios keys so I changed the one for XE to be cisco_xe. I'd match it in the forward but the XE library mapping in Nautobot is missing some essential bits for IOS-XE.

itdependsnetworks commented 4 months ago

We generally do the XE in 1 direction, but not the other https://github.com/networktocode/netutils/blob/7e038fbc0b86a3a9fb410c6b9d5b2ed9e52c36f1/netutils/lib_mapper.py#L502

itdependsnetworks commented 4 months ago

Sorry, should have mentioned (and we should add to the docs), need to add to https://github.com/networktocode/netutils/blob/3b1004eaa66b00bf85475b3a8254c580e2a097e0/development_scripts.py#L37 and then run the development_script (if you run tests, it will tell you the command).

jdrew82 commented 4 months ago

Sorry, should have mentioned (and we should add to the docs), need to add to https://github.com/networktocode/netutils/blob/3b1004eaa66b00bf85475b3a8254c580e2a097e0/development_scripts.py#L37 and then run the development_script (if you run tests, it will tell you the command).

Doh! I always forget to do that for this project...

itdependsnetworks commented 4 months ago

In fairness, we should have it documented.

itdependsnetworks commented 4 months ago

now you have to re-run development script.

jdrew82 commented 4 months ago

now you have to re-run development script.

Sorry, meant to run that. Should be done now.