search

networktocode / ntc-ansible

Multi-vendor network modules
Other
278 stars 112 forks source link

restructure to ansible collection and add ntc dev standards #268

Closed jeffkala closed 1 year ago

jeffkala commented 2 years ago

Would need to determine if a beta is needed, def. would need to be a major release. I think I caught everything, but maybe @gsnider2195 can take a look?

gsnider2195 commented 2 years ago

There's a space at the beginning of your tests directory

gsnider2195 commented 2 years ago

It wouldn't hurt to resolve the shebang issues found with ansible-test sanity:

ERROR: Found 12 shebang issue(s) which need to be resolved:
ERROR:  tests/sanity/.gitkeep:0:0: file without shebang should not be executable
ERROR:  tests/unit/filter/.gitkeep:0:0: file without shebang should not be executable
ERROR:  tests/unit/modules/.gitkeep:0:0: file without shebang should not be executable
ERROR: .bandit.yml:0:0: file without shebang should not be executable
ERROR: .flake8:0:0: file without shebang should not be executable
ERROR: .github/CODEOWNERS:0:0: file without shebang should not be executable
ERROR: .yamllint.yml:0:0: file without shebang should not be executable
ERROR: Dockerfile:0:0: file without shebang should not be executable
ERROR: galaxy.yml:0:0: file without shebang should not be executable
ERROR: plugins/README.md:0:0: file without shebang should not be executable
ERROR: poetry.lock:0:0: file without shebang should not be executable
ERROR: tasks.py:0:0: file without shebang should not be executable
gsnider2195 commented 2 years ago

examples.md should be updated to use the FQCN for module names. For example:

  tasks:

    - name: GET VLANS IN REAL TIME
      ntc_show_command:
        connection: ssh

should be

  tasks:

    - name: GET VLANS IN REAL TIME
      networktocode.ntc_ansible.ntc_show_command:
        connection: ssh
jeffkala commented 2 years ago

It wouldn't hurt to resolve the shebang issues found with ansible-test sanity:

ERROR: Found 12 shebang issue(s) which need to be resolved:
ERROR:  tests/sanity/.gitkeep:0:0: file without shebang should not be executable
ERROR:  tests/unit/filter/.gitkeep:0:0: file without shebang should not be executable
ERROR:  tests/unit/modules/.gitkeep:0:0: file without shebang should not be executable
ERROR: .bandit.yml:0:0: file without shebang should not be executable
ERROR: .flake8:0:0: file without shebang should not be executable
ERROR: .github/CODEOWNERS:0:0: file without shebang should not be executable
ERROR: .yamllint.yml:0:0: file without shebang should not be executable
ERROR: Dockerfile:0:0: file without shebang should not be executable
ERROR: galaxy.yml:0:0: file without shebang should not be executable
ERROR: plugins/README.md:0:0: file without shebang should not be executable
ERROR: poetry.lock:0:0: file without shebang should not be executable
ERROR: tasks.py:0:0: file without shebang should not be executable

so these should have a shebang? I understand them for a python file but not for a non-python file.

jeffkala commented 2 years ago

Looking into reworking all modules to all use pyntc methods for uniformity. Currently some use pyntc methods and others use other solutions, multiple include libraries that don't appear to be maintained any longer.

jeffkala commented 1 year ago

Still got some work to do, will change to DRAFT, some of the modules dont work fully

jeffkala commented 1 year ago

temporarily putting this on hold until pyntc has implemented a few fixes and gets 1.0.0 released.

jeffkala commented 1 year ago

Working through the remaining pieces on this so we can get jdiff incorporated and the collection published.

jeffkala commented 1 year ago

Think this is now ready. Since the decision was to call the collection networktocode.netauto need to determine if this repo actually needs to be renamed or not. Would be great to get this pushed through so the other pending PRs for jdiff and netcompare can get pushed in to maximize the use cases for this collection.

jeffkala commented 1 year ago

fixes #259 fixes #271