networktocode / ntc-netbox-plugin-onboarding

A plugin for NetBox to easily onboard new devices.
Other
246 stars 46 forks source link

Onboarding Device Via Name Fails with 2.0 #106

Closed jvanderaa closed 3 years ago

jvanderaa commented 3 years ago

Environment

Steps to Reproduce

  1. Create a new onboarding task with DNS name of "rtr-branch"
  2. Verify DNS resolution works
  3. Find that the onboarding task is reporting ['Invalid IP address format: rtr-branch']

Expected Behavior

Onboarding to occur

Observed Behavior

['Invalid IP address format: rtr-branch']

mzbroch commented 3 years ago

@jvanderaa Please provide us with exact logs of this issue - without a traceback I can not resolve this issue

mzbroch commented 3 years ago

This is a warning message and should not prevent the task from running.

Existing devices are identified by IP lookups against primary_ip4__address__net_host. This function currently does not work with FQDNs and this was the initial intention. I am open for seeing a PR with this function :-)