search

networktocode / ntc-netbox-plugin-onboarding

A plugin for NetBox to easily onboard new devices.
Other
246 stars 46 forks source link

Napalm and Netmiko optional arguments support #108

Closed carbonarok closed 3 years ago

carbonarok commented 3 years ago

PR extends the onboarding plugin with possibility of specifying optional arguments for Netmiko And NAPALM connections. The Netmiko connection is being used to discover the netmiko device type. Napalm connection is being used to get facts from a device.

Optional arguments are loaded in the following manner : 1) Username and password are derived from task or settings.NAPALM_USERNAME and PASSWORD 2) Secret : # 1 Task's input, # 2 platform's optional arguments as specified in the task, # 3 settings.NAPALM_ARGS 3) optional_args : # 1 otm.optional_args , # 2 settings.NAPALM_ARGS,

Closes issues #80, #102, #103

mzbroch commented 3 years ago

Fixes for issues #80, #102, #103

@carbonarok Can you please appear as a single change - 1 commit, 1 file modified within a PR.

Please make sure the build is passing

glennmatthews commented 3 years ago

Looks reasonable to me; would be nice to have some unit tests though.