Improve search for existing objects

dgarros commented 4 years ago

Fixes #52

Update the search query for existing Device, DeviceType and DeviceRole to be case insensitive
For DeviceType, search for a match on Model and Part Number as well as slug

dgarros commented 4 years ago

After discussing with @mzbroch this PR needs more work

mzbroch commented 3 years ago

@dgarros I like the idea of extending the search scope, although ideally we could have this as a controllable setting, ie:

"object_match_strategy": ["strict", "loose"] (or similar)

For now I would focus on Device Type and Manufacturer only (ones the most exposed to have many value variants of the same thing (ie. model or vendor name), so I would not be extending the approach to a DeviceRole or Device hostname.

PR for this should also cover issue #79 - validate how slugify functions from NetBox UI (javascript) differs from django's, including if we need to remove unicode characters that we can't encode into ASCII

dgarros commented 3 years ago

Closing for now since we are moving this effort to 2.0.0

networktocode / ntc-netbox-plugin-onboarding

Improve search for existing objects #77