networktocode / ntc-netbox-plugin-onboarding

A plugin for NetBox to easily onboard new devices.
Other
246 stars 46 forks source link

Fixes onboarding_extensions_map issue #91

Closed PhillSimonds closed 3 years ago

PhillSimonds commented 3 years ago

This PR addresses the following issues:

dgarros commented 3 years ago

Also @PhillSimonds please can check if we need to fix the logger on other files, would be good to do all at once

glennmatthews commented 3 years ago

Since you're fixing the logging, consider enabling logging for rq.worker in development/base_configuration.py. Something like:

LOGGING = {
    "version": 1,
    "disable_existing_loggers": False,
    "formatters": {"rq_console": {"format": "%(asctime)s %(message)s", "datefmt": "%H:%M:%S",},},
    "handlers": {
        "rq_console": {
            "level": "DEBUG",
            "class": "rq.utils.ColorizingStreamHandler",
            "formatter": "rq_console",
            "exclude": ["%(asctime)s"],
        },
    },
    "loggers": {"rq.worker": {"handlers": ["rq_console"], "level": "DEBUG",}},
}
PhillSimonds commented 3 years ago

Cool! I'll throw something in!

dgarros commented 3 years ago

@glennmatthews @mzbroch Anything else missing before we can merge this one ? it would be useful to get a beta2 ASAP with these fixes. My recommendation would be to add more unit tests in a separate PR.