search

networktocode / ntc-rosetta

The missing bridge between industry standard CLIs and YANG
https://ntc-rosetta.readthedocs.io/en/latest/index.html
Apache License 2.0
103 stars 23 forks source link

Correct annotation on linter #31

Closed dgjustice closed 3 years ago

dgjustice commented 4 years ago

Yangify specifies ignore: Optional[Set[str]] = None, and ntc_yang complaints if more than one ignore string is passed to it.

FragmentedPacket commented 4 years ago

@dgjustice Do mind putting in steps on how to reproduce or where this is in the code? I see it within the Yangify repo, but not entirely sure what the issue is.

dgjustice commented 4 years ago

My apologies, I guess I was in a rush when I jotted down this note, and left no relevant details for you... or my future self. I'm not sure what exactly I was doing that triggered the complaint I mentioned above. However, I do see a type mismatch (which I believe is the real issue) between ntc-rosetta and yangify. https://github.com/networktocode/ntc-rosetta/blob/develop/ntc_rosetta/cli/linter.py#L40 versus https://github.com/networktocode/yangify/blob/develop/yangify/linter/__init__.py#L81 The signature in the yangify module is repeated several times. I assume mypy complained somewhere along the way, so I'll have to dig in and see if I can recreate whatever I found.

itdependsnetworks commented 4 years ago

Did you have your coffee yet?