Implement openconfig-system for IOS

networktocode / ntc-rosetta

The missing bridge between industry standard CLIs and YANG

https://ntc-rosetta.readthedocs.io/en/latest/index.html

Apache License 2.0

103 stars 23 forks source link

Implement openconfig-system for IOS #33

Closed dgjustice closed 4 years ago

dgjustice commented 4 years ago

This one probably needs a bit of discussion, so please review closely. "replace" operations don't always make sense on IOS, particularly for things like system-level config. There is no way to my knowledge to "default" ntp config, tacacs, users, etc. I have raised an exception when replace is called, and the test asserts off of an empty file to diff against. It's a bit hackish, but it works for now.

dgjustice commented 4 years ago

I changed this to WIP after looking at PR #3 again. These two PR's really highlight the need for a little different testing setup. We need to make it easier to assert failures in particular.

FragmentedPacket commented 4 years ago

@dgjustice Just wanted to bump this since we merged in the testing. I know you're busy and no rush, but just wanted to let you know I'll review once it's rebased and testing follows what was merged in.