Adding et, ae, and irb interfaces to junos

networktocode / ntc-rosetta

The missing bridge between industry standard CLIs and YANG

https://ntc-rosetta.readthedocs.io/en/latest/index.html

Apache License 2.0

103 stars 23 forks source link

Adding et, ae, and irb interfaces to junos #6

Closed dgjustice closed 5 years ago

dgjustice commented 5 years ago

I looked at one of our switches, and it shows the ae and irb interfaces as loopbacks, so I hope software loopback is the appropriate iana-if-type. et is a 40G physical.

show interfaces irb snmp-index 0                                                                                                                                                                                                  
Physical interface: .local., Enabled, Physical link is Up                                                                                                                                                                                                
  Interface index: 0, SNMP ifIndex: 0                                                                                                                                                                                                                    
  Type: Loopback, Link-level type: Interface-Specific, MTU: Unlimited, Speed: Unlimited

dbarrosop commented 5 years ago

Awesome, it has even tests :D

Couple of comments though:

ae should be of type iana-if-type:ieee8023adLag
if irb is a vlan interface, which I think it is, it should be iana-if-type:l3ipvlan

dgjustice commented 5 years ago

@dbarrosop Let me know how this looks. Updated per your comments. Thanks for looking up those iftypes, I couldn't find them!

dgjustice commented 5 years ago

Also, where did you find the proper iftype? I'm sure this will pop up again in the future.

dbarrosop commented 5 years ago

You can find those here: https://tools.ietf.org/html/rfc7224