search

networktocode / ntc-templates

TextFSM templates for parsing show commands of network devices
https://ntc-templates.readthedocs.io/
Other
1.12k stars 730 forks source link

New template: Aruba Procurve `show version` #1862

Closed evilmonkey19 closed 1 month ago

evilmonkey19 commented 1 month ago

Personally, I don't know the difference between ArubaOS and Aruba Procurve. However, in the device i'm testing against using Netmiko, aruba_procurve works fine and aruba_os doesn't. 😅

evilmonkey19 commented 1 month ago

Yes! It is the same 👌 https://github.com/ktbyers/netmiko/blob/eab18842d38e5993f39ca010a970ce6687797d75/netmiko/ssh_dispatcher.py#L172

evilmonkey19 commented 1 month ago

It is fine to put into hp_procurve, but i want to use aruba_procurve as the platform. does it work in ntc_templates?

jmcgill298 commented 1 month ago

It is fine to put into hp_procurve, but i want to use aruba_procurve as the platform. does it work in ntc_templates?

That can be done by changing the index file to use (hp|aruba)_procurve, but I suspect that might break are testing framework (should be fixable though)

jmcgill298 commented 1 month ago

@evilmonkey19 can you test https://github.com/evilmonkey19/ntc-templates/pull/2 to see if that works for you?

evilmonkey19 commented 1 month ago

During the weekend I will try to fix it :)

evilmonkey19 commented 1 month ago

In local development it works using the aruba_procurve platform if you do the little change in the index. Personally, I'm in favor of testing everything but in this case it is just a small change that would test the same result against the same platform. I don't have further testing should be required.

The testing suite is using the hp_procurve option and not the aruba_procurve, but the tests would be exactly the same in both cases.

TLDR: using aruba_procurve is the same as using hp_procurve