Fix Fortinet get system interface template and combine rules

networktocode / ntc-templates

TextFSM templates for parsing show commands of network devices

https://ntc-templates.readthedocs.io/

Other

1.12k stars 730 forks source link

Fix Fortinet get system interface template and combine rules #1874

Closed mjbear closed 1 month ago

mjbear commented 1 month ago

resolves #1594 bug fix / enhancement

brought over @GustavoMaga's template change
didn't have test data for old 6.4 version, but did supplant it with 7.0 test data
found an additional wan line that needed a rule created
combined version specific rules by making certain items optional
- greatly reduced the template noise overall

Huge thanks to @pnpestov for raw test data!

mjbear commented 1 month ago

@PavloSkliarenko @pnpestov @refriedjello @GustavoMaga Are any of you interested in testing these Fortinet get system interface template changes on real live hardware?

Thank you!

mjbear commented 1 month ago

@pnpestov Might you be willing to test get system interface on live Fortinet gear as well?

pnpestov commented 1 month ago

Are any of you interested in testing these Fortinet get system interface template changes on real live hardware?

@mjbear Good day! Yes, it really works with software version 7.0.15

mjbear commented 1 month ago

Are any of you interested in testing these Fortinet get system interface template changes on real live hardware?

@mjbear Good day! Yes, it really works with software version 7.0.15

Great! Thank you for testing! @pnpestov