Closed jnicholson56 closed 4 days ago
Adding various templates to parse operational data.
@jnicholson56 Welcome to the project.
Including changes for multiple templates in a single PR (pull request) is tough. (Although it doesn't seem there's a written rule in the contributing guidelines, it is common not to lump a pile of changes in a single PR.)
A normal workflow is to create a feature branch off the master
branch (or main
for some repos) and make your changes in just that feature branch. Then when submitting a PR, compare that feature branch against the upstream (in this case ntc-templates repo).
If I don't ask, the maintainers will probably ask... Could you to please split out your PR so that each template has its own PR?
@jnicholson56 Apologies if I came across the wrong way. Text doesn't communicate emotion or my intent to collaborate and help.
You even had the test data! Kudos!
If I can be of assistance or review please let me know.
Adding various templates to parse operational data.