networktocode / ntc-templates

TextFSM templates for parsing show commands of network devices
https://ntc-templates.readthedocs.io/
Other
1.09k stars 712 forks source link

cisco_wlc_ssh update name to cisco_wlc? #409

Open jvanderaa opened 5 years ago

jvanderaa commented 5 years ago
ISSUE TYPE
TEMPLATE USING
cisco_wlc_ssh*
SAMPLE COMMAND OUTPUT
SUMMARY

Other systems are jumping in and working in conjunction with NTC templates. Specifically Netmiko integration in this issue. The name for wireless is typically cisco_wlc in Netmiko, which then does not find an NTC template in the home directory. As a work around the device_type of cisco_wlc_ssh does work, but seems a little out of the ordinary to use with Netmiko since it is SSH by using it.

Would like to remove the _ssh suffix on the cisco_wlc_ssh names to assist with this. Are there other non-ssh templates for this?

jmcgill298 commented 5 years ago

I need to think more about potential impact on others projects that have this as a dependency, but I created this TODO when I upgraded the testing

https://github.com/networktocode/ntc-templates/blob/7ddc227d2d7f5b71c66618552db33ce752c660b1/tests/test_testcases_exists.py#L20

robobeaver6 commented 5 years ago

I just spotted this as well as I was running the tests for PR #418 . The rules of the index file specifically state the OS need to be a netmiko OS type, which is cisco_wlan_ssh, so I think it would need to be changed there first.

I wasn't raising that PR for this issue, but in changing the way the command and OS is compared, the test failed because the list of accepted types in the test was wrong (missing the _ssh). If it gets removed as part of an update to netmiko, that is fine, so long as the test here is also updated to reflect the change.

mjbear commented 1 month ago

Now that Cisco's recent WLCs run IOS-XE this may not be worth changing in both netmiko or ntc-templates projects.

For the common show commands the IOS-XE WLCs can utilize the normal cisco_ios templates. In practice the output for wireless related commands can be different than the AireOS WLCs.