Use of signal in ios_device during reboot, limits the ability to run within threads.

networktocode / pyntc

Python library focused on tasks related to device level and OS management.

https://pyntc.readthedocs.io/en/latest/

Other

170 stars 52 forks source link

Use of signal in ios_device during reboot, limits the ability to run within threads. #274

Closed jeffkala closed 1 year ago

jeffkala commented 1 year ago

https://github.com/networktocode/pyntc/blob/c9c1a9d3e965b1998103ca59e0fd2244fbd8eac1/pyntc/devices/ios_device.py#L920

I don't see this being required, we have some other methods now to determine when a device is back up after a reboot. @jmcgill298 do you know the original reason signal was used here(within cisco devices) and not in any of the other device drivers?

jmcgill298 commented 1 year ago

@jeffkala I think this is used to force a reset stale ssh sessions once the channel has been broken by the reboot.

jeffkala commented 1 year ago

closed in #280