networktocode / pyntc

Python library focused on tasks related to device level and OS management.
https://pyntc.readthedocs.io/en/latest/
Other
170 stars 52 forks source link

Netmiko delay_factor issue. #303

Closed pszulczewski closed 11 months ago

pszulczewski commented 11 months ago

Describe issue

Netmiko 4.X has deprecated the use of delay_factor in favor of read_timeout, it's still supported, but connection object must be initialized with delay_factor_compat=True, which is set by default to False. pytntc doesn't set that argument, so netmiko falls back to read_timeout which default is set to 10, regardless of delay_factor setting.

Environment

Expected Behavior

install_os() command delay can be controlled with with function argument.

Observed Behavior

delay_factor is not respected in netmiko 4.X when delay_factor_compat=True is not set in the connection object.

Steps to Reproduce

Run install_os for cisco_ios, after 10 sec netmiko.exceptions.ReadTimeout is raised regardless of delay factor.