CI spellcheck broken - Githubissues

networkupstools / nut-website

Network UPS Tools website and protocol library

6 stars 14 forks source link

CI spellcheck broken #21

Closed jimklimov closed 2 years ago

jimklimov commented 3 years ago

Spellcheck jobs on Travis CI keep complaining about words in nut-website text files that are covered in nut/doc/nut.dict that is supposedly used. Similar runs on local workstation work without errors.

It is possible that the spellcheck related Makefile hardcodes a bit too much, so I began experimenting with a more flexible mechanism that could be more easily and reliably hijacked by consumers from other Makefiles (man pages subdir did so etc. already, website now also a focus point).

jimklimov commented 3 years ago

These two branches should experiment the new arrangement:

https://github.com/networkupstools/nut/tree/nonabs-nut-dict => builds of NUT itself with spellcheck not broken per https://travis-ci.org/github/networkupstools/nut/builds/751506287 (also tested locally, and with make-spellcheck-interactive too)
https://github.com/networkupstools/nut-website/tree/nonabs-nut-dict => https://travis-ci.org/github/networkupstools/nut-website/builds/751506571

jimklimov commented 3 years ago

Good news: the proposed mechanism works and does not break NUT builds. Bad news: CI spellcheck for nut-website still complains.

jimklimov commented 2 years ago

Tech got fixed with other changes over time. Not a problem with NUT CI at least.

Dictionary does need an update however, and the spellcheck is not called from build.

jimklimov commented 2 years ago

Site-publishing job in CI (and the ci_build.sh script running for non-historic builds) should now check site text spelling too.