networkupstools / nut-website

Network UPS Tools website and protocol library
6 stars 14 forks source link

"Download sources" page should offer newest *release*, not just newest tag #34

Closed jimklimov closed 1 year ago

jimklimov commented 1 year ago

NUT repository has a number of tags for intermediate milestones during development, which are not releases (candidates, major side project merges).

However the website links from https://networkupstools.org/download.html#_stable_tree_2_8 seem to report just the newest (possibly annotated) git tag => inspired link. For example, at the moment it suggests http://www.networkupstools.org/source/2.8/nut-2.8.0-Windows.tar.gz which is not even published among sources (separate repo) which may in fact be a criterion for choosing what maintainers think is a release - just pick the newest of those.

jimklimov commented 1 year ago

Looking at https://github.com/networkupstools/nut/blob/f236b5e60837680223af83ff8c69460f862eba52/docs/download.txt#L23-L33 the practical problem is determining the revision correctly - seeded to PACKAGE_VERSION in https://github.com/networkupstools/nut-website/blob/64361632b90ed427b5bc2e364e37ccdc8118ffe6/Makefile.am#L89-L90

This brings the issue closer to #35 and https://github.com/networkupstools/nut/issues/1949 ...

jimklimov commented 1 year ago

Seems --match 'v[0-9]*.[0-9]*.[0-9]-signed' --match 'v[0-9]*.[0-9]*.[0-9]' --exclude '*rc*' --exclude '*alpha*' --exclude '*beta*' args to git describe can do the trick...

jimklimov commented 1 year ago

...or perhaps without the -signed tags, to avoid confusing "nut-2.8.0-signed.tar.gz" expectations.

jimklimov commented 1 year ago

fixed with today's website builds