jimklimov
commented
9 months ago I agree, and a PR is welcome :)
For context, not always not everywhere logs are monitored (so as to make alerts) from them in real time. As a side note, NUT probably predates most of the fancier log-monitoring systems you see today, so the unseen/unborn techs were not a factor in the original design :)
In fact, upsmon has "notifications" to WALL/SYSLOG/EXEC for a number of events and state changes, and those are throttled (IIRC e.g. walling once in 5 mins by default for Data Stale).
no logical sense to repeat...
I believe it just runs the polling loop and reports encountered errors. To stderr typically, which is then sysadmin's or packager's "fault" if it ends up logged (though maybe upsdebugx()/upslogx() does ditto or redirect to syslog at some point like forking and/or based on internal config). It is extra work to remember that the same error was reported on last cycle (such work is the welcome PR) and e.g. report it only for non-zero debug verbosity for some time. Probably the throttling approavh for notifications can be used here.
mailinglists35
When
nut-monitorcannot talk to/lib/nut/$whatever-driver, or when the communication between the driver and the ups is unavailable, it repeats this message in logs:I wish it allowed a configuration directive or a command line argument to only print this message once. the polite behaviour is already exhibited by
upsd, that only prints an equivalent message once:the repeating of message every 5 seconds in logs provides no use to me, and only annoyance instead.
this is literally the equivalent of ups emiting audible beeps - that makes sense in physical world as having the role of catching a human's attention that might not be near it all the time, so it makes perfect sense to repeat the beep, because in physical world you cannot roll back in time to listen to sounds in a room (unless you have a sound recording device)
however in electronic world the logs are monitored, and a single line is sufficient to trigger an alert, because unlike in physical world, an alert does not dissapear once it has been produced, and someone will be able to read it any time later, thus it make no logical sense to repeat the line.
the same when comm is lost: upsd politely tells me once
while upsmon begins spamming the logs every 5 seconds: