networkupstools / nut

The Network UPS Tools repository. UPS management protocol Informational RFC 9271 published by IETF at https://www.rfc-editor.org/info/rfc9271 Please star NUT on GitHub, this helps with sponsorships!
https://networkupstools.org/
Other
2.04k stars 349 forks source link

SNMP: eaton-ups-pwnm2-mib.c: two same numeric IDs in a lookup table #2303

Open jimklimov opened 8 months ago

jimklimov commented 8 months ago

https://github.com/networkupstools/nut/blob/dcbb2ba041fd1feaff924f3edd388d2f75c350ae/drivers/eaton-ups-pwnm2-mib.c#L121-L124

@aquette : the two 11 values here, also in original code before the change - which one is right and which is a typo?

_Originally posted by @jimklimov in https://github.com/networkupstools/nut/pull/2285#discussion_r1484273011_

jimklimov commented 8 months ago

Looked for these OIDs, and it seems to be originally xupsOutputSource from XUPS-MIB (which only went up to 10 in enum values), supplanted by PowerMIB which as of 2011 included the maintenanceBypass(11) entry:

https://www.eaton.com/content/dam/eaton/products/backup-power-ups-surge-it-power-distribution/power-management-software-connectivity/eaton-network-card-ms/eaton-ups-power-mib-release-notes.txt

Similarly in CPQPower MIB at http://www.circitor.fr/Mibs/Html/C/CPQPOWER-MIB.php (up to 10'th enum value though, with a different OID prefix).

Was there a published Eaton MIB (probably after 2011) that actually mentioned an "ESS mode" in some fashion?

jimklimov commented 3 months ago

@arnaudquette-eaton : gentle bump :)