search

networkupstools / nut

The Network UPS Tools repository. UPS management protocol Informational RFC 9271 published by IETF at https://www.rfc-editor.org/info/rfc9271 Please star NUT on GitHub, this helps with sponsorships!
https://networkupstools.org/
Other
1.99k stars 349 forks source link

Import from FTY branch: `do_convert_deci` support in `drivers/netxml-ups.c`? #2342

Closed jimklimov closed 2 months ago

jimklimov commented 7 months ago

Follow-up from #2275

Currently the FTY branch includes code for decimal conversions with very old MGE devices. It is mentioned in netxml-ups and mge-xml codebases. I am not sure if it even is not a mis-merge of some earlier resyncs from master to FTY, as some of those commits purported to relocate or drop this... I think.

jimklimov commented 2 months ago

Per analysis in #1316,

actually the FTY part should be dropped, left-over from when the do_convert_deci toggle was converted from boolean setting into a flag checked right in mge-xml.c; will be posted in #2472 resync