search

networkx / networkx-metis

NetworkX Addon to allow graph partitioning with METIS
Other
78 stars 21 forks source link

Identation fix in types.py #17

Closed OrkoHunter closed 9 years ago

OrkoHunter commented 9 years ago

Wow, theses little things I didn't notice. Thanks Travis.

chebee7i commented 9 years ago

Is this going into the right repository? Looks like it is going into networkx:master.

OrkoHunter commented 9 years ago

Well this PR is #17 of networkx-metis seeing from URL. And networkx doesn't even have any networkx.addons.metis.types. I think the scheme of that is <username>:<branch> and <organization>:<branch>. Nothing to do with repository in both case.

chebee7i commented 9 years ago

Strange that I never noticed it before...and it indeed the same on other PRs. But it still seems out. The syntax is: repositoryname:branchname. So when it says:

OrkoHunter  wants to merge 1 commit into networkx:master from OrkoHunter:types_fix

the definitely seems "off".

chebee7i commented 9 years ago

In the repository settings, is there some way to specify this and it is just specified wrong?

chebee7i commented 9 years ago

Looks like it is ubiquitous. The format is actually username:branchname. So like you said, the repository name is not part of it.

OrkoHunter commented 9 years ago

Maybe it's a new change? That's why we never noticed it earlier.