Change test_metis.py to test the exposed functions

networkx / networkx-metis

NetworkX Addon to allow graph partitioning with METIS

Other

79 stars 21 forks source link

Change test_metis.py to test the exposed functions #26

Closed ysitu closed 9 years ago

ysitu commented 9 years ago

We should not be directly testing functions from _metis.pyx as those are implementation detail.

OrkoHunter commented 9 years ago

Okay.. So rather we'd be testing the functions present in the top level of networkx.addons.metis. Still didn't get what is going wrong with testing the _metis.pyx functions.

ysitu commented 9 years ago

That is about the philosophy of testing. Impose constraints on only the public interfaces so that you are handcuffed to the implementation details.

ysitu commented 9 years ago

@OrkoHunter Can you prioritize this?

OrkoHunter commented 9 years ago

Sure. This is a must. I'll be sending a PR shortly.